Implement heuristic to extract comments from message files#323
Merged
dirk-thomas merged 1 commit intomasterfrom Nov 15, 2018
Merged
Implement heuristic to extract comments from message files#323dirk-thomas merged 1 commit intomasterfrom
dirk-thomas merged 1 commit intomasterfrom
Conversation
e974f38 to
332206a
Compare
332206a to
952fb47
Compare
mjcarroll
approved these changes
Nov 15, 2018
Member
mjcarroll
left a comment
There was a problem hiding this comment.
This looks to correctly implement what was discussed in #316. I saw @jacobperron's most recent comment (#316 (comment)), but I don't believe that it's a blocker here, because I haven't seen that in any messages that I can recall.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the second PR integrating #298 step-by-step.
Builds on top of #322.
Implements #316.
Linux CI: