Skip to content
This repository was archived by the owner on Jan 11, 2019. It is now read-only.

add bouncy distro#79

Merged
mikaelarguedas merged 2 commits intoros2from
bouncy
Jun 4, 2018
Merged

add bouncy distro#79
mikaelarguedas merged 2 commits intoros2from
bouncy

Conversation

@mikaelarguedas
Copy link
Copy Markdown
Member

This currently adds only bionic as a targeted platform.

@nuclearsandwich to give feedback on if we can / want to provide metadata for Ubuntu Xenial and Debian Stretch

@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich to give feedback on if we can / want to provide metadata for Ubuntu Xenial and Debian Stretch

Enabling additional distros we're not building means we have to decide how best to apply release patches for those distros. For rmw_implementations we add release time dependencies on the supported rmw implementation libraries. On bionic that's fastrtps and opensplice, but we don't build opensplice for Debian stretch to my knowledge. So does it make sense to generate metadata for a package whose dependencies aren't available? Does it make sense to do extra work to generate metadata for distributions we aren't primarily supporting?

I think there are fewer release patching discrepancies between bionic and xenial but if there are vendor packages that can no longer use the xenial system version but can use the bionic system version, that would be a possible divergence.

@mikaelarguedas
Copy link
Copy Markdown
Member Author

thanks @nuclearsandwich for the feedback

So does it make sense to generate metadata for a package whose dependencies aren't available? Does it make sense to do extra work to generate metadata for distributions we aren't primarily supporting?

Yeah that's a good point. No I don't think we should do extra work just to be able to generate metadata. We will get there eventually but it shouldnt be added to the tasklist of this release.

I think there are fewer release patching discrepancies between bionic and xenial but if there are vendor packages that can no longer use the xenial system version but can use the bionic system version, that would be a possible divergence.

At least for Bouncy, we require to be able to still be able to build from source so we shouldn't stop vendoring packages that are not available on xenial. So in this case that should be fine.

Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but probably want other reviews that know the consequences better.

@mikaelarguedas mikaelarguedas merged commit e337085 into ros2 Jun 4, 2018
@mikaelarguedas mikaelarguedas deleted the bouncy branch June 4, 2018 12:53
dirk-thomas pushed a commit that referenced this pull request Jan 10, 2019
* add bouncy

* add xenial to the list of platforms to generate metadata for it
dirk-thomas pushed a commit to ros/rosdistro that referenced this pull request Jan 10, 2019
* add bouncy

* add xenial to the list of platforms to generate metadata for it
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants