Fix deprecated subscriber callback warnings#852
Merged
emersonknapp merged 1 commit intoros2:masterfrom Aug 24, 2021
aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
Merged
Fix deprecated subscriber callback warnings#852emersonknapp merged 1 commit intoros2:masterfrom aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
emersonknapp merged 1 commit intoros2:masterfrom
aprotyas:aprotyas/deprecate-shared-ptr-sub-callback
Conversation
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org>
Member
Author
|
CI (build/test:
|
wjwwood
approved these changes
Aug 21, 2021
emersonknapp
approved these changes
Aug 24, 2021
WJaworskiRobotec
pushed a commit
to RobotecAI/rosbag2
that referenced
this pull request
Sep 12, 2021
Signed-off-by: Abrar Rahman Protyasha <abrar@openrobotics.org> Signed-off-by: Wojciech Jaworski <wojciech.jaworski@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rclcpp#1713 deprecates the
void shared_ptr<T>subscription callback signatures, so this PR migrates away from said signatures.Signed-off-by: Abrar Rahman Protyasha abrar@openrobotics.org