Fix rosbag2_py on Windows debug and stop ignoring the package#531
Merged
Fix rosbag2_py on Windows debug and stop ignoring the package#531
Conversation
Member
Author
|
f361135 to
a3bd925
Compare
jacobperron
reviewed
Oct 2, 2020
Member
jacobperron
left a comment
There was a problem hiding this comment.
Thanks for figuring this out 🙇
mabelzhang
reviewed
Oct 3, 2020
Contributor
mabelzhang
left a comment
There was a problem hiding this comment.
Looks good! I think the yellow is the linter complaining about something. Approve on green CI
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
9b14e40 to
35fe856
Compare
Member
Author
|
CI jobs (lots of them):
|
Karsten1987
approved these changes
Oct 5, 2020
Member
Author
|
Going in, thanks for the review @Karsten1987! |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 16, 2021
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 23, 2021
Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
sloretz
added a commit
to ros2/rclpy
that referenced
this pull request
Feb 24, 2021
* Copy windows debug fixes for pybind11 Copies windows debug fixes from rosbag2_py for using Pybind11 on Windows debug and RelWithDebInfo. For more info see the original PRs ros2/rosbag2#538 ros2/rosbag2#531 Signed-off-by: Shane Loretz <sloretz@openrobotics.org> Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Workaround for consistent Py_DEBUG macro Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * fix argument order Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Does PUBLIC Py_DEBUG resolve differences? Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Don't include Python.h if including pybind11.h Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Remove Py_DEBUG if target doesn't use pybind11 Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #529.Fixes #504.
This deletes the
AMENT_IGNOREfile inrosbag2_pyfolder, as the two issues has been fixed now.