Skip to content

Use new ROSIDL aggregate CMake target#2384

Merged
ahcorde merged 1 commit intorollingfrom
emerson/rosidl_aggregate_targets
Mar 24, 2026
Merged

Use new ROSIDL aggregate CMake target#2384
ahcorde merged 1 commit intorollingfrom
emerson/rosidl_aggregate_targets

Conversation

@emersonknapp
Copy link
Copy Markdown
Collaborator

Description

Use new targets from ros2/rosidl#947

Is this user-facing behavior change?

no

Did you use Generative AI?

no

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Mar 23, 2026

@ahcorde ahcorde merged commit 8b962b5 into rolling Mar 24, 2026
11 of 12 checks passed
tonynajjar added a commit to botsandus/rosbag2 that referenced this pull request Mar 28, 2026
tonynajjar added a commit to botsandus/rosbag2 that referenced this pull request Mar 28, 2026
@MichaelOrlov MichaelOrlov deleted the emerson/rosidl_aggregate_targets branch March 28, 2026 21:32
@MichaelOrlov
Copy link
Copy Markdown
Contributor

@emersonknapp @ahcorde It seems you broke Rpr CI job with this PR.
The rosbag2_transport now fails on all other PRs with the following errors

-- Found rosbag2_interfaces: 0.33.0 (/tmp/ws/install_isolated/rosbag2_interfaces/share/rosbag2_interfaces/cmake)
15:17:21 -- Configuring done (1.2s)
15:17:21 CMake Error at CMakeLists.txt:62 (target_link_libraries):
15:17:21   Target "rosbag2_transport" links to:
15:17:21 
15:17:21     rosbag2_interfaces::rosbag2_interfaces
15:17:21 
15:17:21   but the target was not found.  Possible reasons include:
15:17:21 
15:17:21     * There is a typo in the target name.
15:17:21     * A find_package call is missing for an IMPORTED target.
15:17:21     * An ALIAS target is missing.

I also can't figure out what's wrong with the rosbag2_interfaces package. Can you please help with fixing it?

@emersonknapp
Copy link
Copy Markdown
Collaborator Author

Remember, that's normal on rolling, it's building only against the latest bloom released debs - Rpr doesn't build against latest sources. Just have to rely on ci.ros builds until next rolling bloom of rcl_interfaces. Which we should do soon

@tonynajjar
Copy link
Copy Markdown
Contributor

@emersonknapp I also get the error when building locally rosidl and e.g. rosbag2 packages on rolling. What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants