[kilted] Use rclcpp type support helpers in rosbag2_cpp (backport #2017)#2129
Merged
MichaelOrlov merged 1 commit intokiltedfrom Sep 16, 2025
Merged
[kilted] Use rclcpp type support helpers in rosbag2_cpp (backport #2017)#2129MichaelOrlov merged 1 commit intokiltedfrom
MichaelOrlov merged 1 commit intokiltedfrom
Conversation
Signed-off-by: Michael Orlov <morlovmr@gmail.com> (cherry picked from commit bc37cdf)
Contributor
|
Waiting for the next Kilted sync to have dependencies on the rclcpp layer to be available in the binaries. |
Contributor
|
@ros-pull-request-builder retest this please |
Contributor
|
Pulls: #2129
|
MichaelOrlov
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Historically, the type support helpers were implemented in the
rosbag2_cpp/typesupport_helpers.cpp, then the implementation of the major helper functions was added to the core rclcpp package in therclcpp/typesupport_helpers.hpp.However, the original implementation was never removed from the
rosbag2_cpppackage.This PR replaces original type support helpers in the
rosbag2_cppwith the same functions from the corerclcpppackage to avoid code duplication and divergences in the future.Additional information
typesupport_helpersAPI needed for the Rosbag2 rclcpp#2858action-ros-ci-repos-supplemental: https://raw.githubusercontent.com/ros2/ros2/rolling/ros2.repos
This is an automatic backport of pull request #2017 done by Mergify.