Skip flaky can_record_again_after_stop test#2031
Merged
MichaelOrlov merged 1 commit intorollingfrom Jun 2, 2025
Merged
Conversation
- Skipping flaky test for a while. Until relevant issue #1914 will be resolved. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
christophebedard
approved these changes
Jun 1, 2025
Contributor
Author
|
Pulls: #2031
|
Contributor
Author
|
https://github.com/Mergifyio backport kilted jazzy |
✅ Backports have been createdDetails
|
MichaelOrlov
added a commit
that referenced
this pull request
Jan 12, 2026
This reverts commit 5a364f7. Signed-off-by: Michael Orlov <morlovmr@gmail.com>
MichaelOrlov
added a commit
that referenced
this pull request
Jan 21, 2026
* Revert "Skip flaky `can_record_again_after_stop` test (#2031)" This reverts commit 5a364f7. Signed-off-by: Michael Orlov <morlovmr@gmail.com> * Explicitly disable subscription's callbacks before its deletion Explicitly disable all subscription's callbacks to avoid UB and receiving new messages on deleted subscriptions. Note: The callbacks propagated to the executor and may still be in the executor's queue, but they will no longer be called after this point. - Depends on the ros2/rclcpp#2985 Signed-off-by: Michael Orlov <morlovmr@gmail.com> --------- Signed-off-by: Michael Orlov <morlovmr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR skipping flaky RecordIntegrationTestFixture.can_record_again_after_stop test from CI run.
Relates The
RecordIntegrationTestFixture.can_record_again_after_stoptest is tend to be flaky #1914Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
Skipping
RecordIntegrationTestFixture.can_record_again_after_stopuntil the relevant issue #1914 is resolved.