Set envars to run tests with rmw_zenoh_cpp with multicast discovery#1946
Set envars to run tests with rmw_zenoh_cpp with multicast discovery#1946
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
MichaelOrlov
left a comment
There was a problem hiding this comment.
Can we somehow reduce the amount of boiler-plate code in this PR?
MichaelOrlov
left a comment
There was a problem hiding this comment.
@ahcorde Could you please consider moving workaround for zenoh router to the downstream layer inside call_for_each_rmw_implementation ?
This way we will not need any changes on Rosbag2 side and perhaps in some other packages too.
We considered this change. But unfortunately setting any envars within the call_for_each_rmw_implementation will not actually forward the envars to the runtime environment of the |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-pmc-minutes-for-march-25-2025/42807/1 |
Signed-off-by: Yadunund <yadunund@gmail.com>
|
Gist (default ros2.repos with changes from this branch): https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/99d863456c5338701720bec4f4b76408651adbe0/ros2_ci.repos
|
MichaelOrlov
left a comment
There was a problem hiding this comment.
@Yadunund I see a bunch of errors like
test_play__rmw_cyclonedds_cpp
2025-03-26T01:49:43.4449996Z <<< failure message
2025-03-26T01:49:43.4450698Z -- run_test.py: extra environment variables:
2025-03-26T01:49:43.4451388Z usage: run_test.py [-h] [--package-name PACKAGE_NAME]
2025-03-26T01:49:43.4452082Z [--command COMMAND [COMMAND ...]] [--env ENV [ENV ...]]
2025-03-26T01:49:43.4452780Z [--append-env APPEND_ENV [APPEND_ENV ...]]
2025-03-26T01:49:43.4453473Z [--output-file OUTPUT_FILE] [--generate-result-on-success]
2025-03-26T01:49:43.4454281Z [--skip-test] [--skip-return-code SKIP_RETURN_CODE]
2025-03-26T01:49:43.4454782Z result_file
2025-03-26T01:49:43.4455342Z run_test.py: error: --env argument 'rmw_implementation_env_var' contains no equal signin the RPR job run. It seems related to the changes from this PR.
Signed-off-by: Yadunund <yadunund@gmail.com>
|
@MichaelOrlov thanks for flagging the errors. I think i've fixed it with b1925ba 🤞🏼 I'm surprised the CI jobs did not fail. Looking at the logs, one can see the same errors https://ci.ros2.org/job/ci_linux/22880/console#console-section-0 🤔 |
|
Gist (default ros2.repos with changes from this branch): https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/99d863456c5338701720bec4f4b76408651adbe0/ros2_ci.repos
|
|
with rmw_zenoh
|
See ros2/rmw_zenoh#567
To test this PR, we can run the usual CI jobs to show there are no regressions and additionally run a CI job with a copy of the ros2.repos file from ros2/ros2#1649 with CI Scripts branch set to yadu/cargo