[jazzy] Remove rcpputils::fs dependencies in rosbag2 packages (backport #1740)#1780
Closed
mergify[bot] wants to merge 1 commit intojazzyfrom
Closed
[jazzy] Remove rcpputils::fs dependencies in rosbag2 packages (backport #1740)#1780mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
MichaelOrlov
approved these changes
Aug 9, 2024
Contributor
MichaelOrlov
left a comment
There was a problem hiding this comment.
This backport will fix failure in github build_and_test CI job due to treating warnings as errors.
Contributor
|
Pulls: #1780
|
Contributor
|
Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 7a01d78)
6a20ba4 to
c941ed3
Compare
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rcpputils::fsin all rosbag2 packages.rcpputils::fswill be deprecated soon, and it is advised thatstd::filesystembe used instead.Added own
rosbag2_test_common::create_temp_directory(..)function in replacement of the analog from thercpputils::fssince such functionality doesn't exists in thestd::filesystem.This is an automatic backport of pull request #1740 done by Mergify.