• This PR fixes StorageTestFixture.throws_on_invalid_pragma_in_config_file test failure on Windows reported in the Use std::filesystem instead of rcpputils::fs #1576 (comment) and Remove rcpputils::fs dependencies in rosbag2 packages #1740 (comment) after replacing
  

  rosbag2/rosbag2_test_common/include/rosbag2_test_common/temporary_directory_fixture.hpp

  Lines 37 to 40 in e860f65

  	~TemporaryDirectoryFixture() override
  	{
  	rcpputils::fs::remove_all(rcpputils::fs::path(temporary_dir_path_));
  	}

  
  with std::filesystem::remove_all(std::filesystem::path(temporary_dir_path_));

RCA (Root Cause Analysis)

The failure was because the database file was not properly closed after throwing an exception from the SqliteWrapper constructor, and std::filesystem::remove_all(..) failed to delete a temporary folder in the test fixture destructor.

Fixes

• I added a reset for the prepared SQL statement before throwing the exception.
• Try to close the database in the constructor if we get an exception after opening the database since the destructor will not be called in this case.