Skip to content

Add compatibility with new IPC implementation#140

Closed
alsora wants to merge 1 commit intoros2:masterfrom
alsora:alsora/fixes_for_new_ipc
Closed

Add compatibility with new IPC implementation#140
alsora wants to merge 1 commit intoros2:masterfrom
alsora:alsora/fixes_for_new_ipc

Conversation

@alsora
Copy link
Copy Markdown
Contributor

@alsora alsora commented Jul 9, 2019

This PR is intended to follow ros2/rclcpp#778 where a new IPC implementation is created.

The new IPC implementation introduces some changes to the Subscription and SubscriptionBase classes that affect this repository.

Signed-off-by: alberto <alberto.soragna@gmail.com>
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR shouldn't be needed.
See my comment here.

@alsora
Copy link
Copy Markdown
Contributor Author

alsora commented Jul 25, 2019

Closing this in favor of #143

@alsora alsora closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants