Skip to content

Fix API for new Intra-Process Communication#143

Merged
clalancette merged 5 commits intoros2:masterfrom
alsora:alsora/fix_for_ipc
Oct 21, 2019
Merged

Fix API for new Intra-Process Communication#143
clalancette merged 5 commits intoros2:masterfrom
alsora:alsora/fix_for_ipc

Conversation

@alsora
Copy link
Copy Markdown
Contributor

@alsora alsora commented Jul 25, 2019

Some small fixes to be compatible with new Intra-Process Communication

Connects to ros2/rclcpp#778

@ivanpauno

@alsora alsora changed the title fix api for new ipc Fix API for new Intra-Process Communication Jul 25, 2019
Copy link
Copy Markdown
Collaborator

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

I am waiting on this until the respective rclcpp PR is addressed. Is that correct?

@alsora
Copy link
Copy Markdown
Contributor Author

alsora commented Jul 26, 2019

Yes exactly.
This PR will be required because some API in PublisherBase and SubscriptionBase have been changed/removed

@alsora alsora force-pushed the alsora/fix_for_ipc branch from d43b402 to 1b6047a Compare July 26, 2019 18:31
@wjwwood wjwwood force-pushed the alsora/fix_for_ipc branch from f3274f8 to 9eb2a9d Compare October 17, 2019 23:27
alsora and others added 5 commits October 18, 2019 16:56
Signed-off-by: Soragna, Alberto <alberto.soragna@gmail.com>
Signed-off-by: Soragna, Alberto <alberto.soragna@gmail.com>
Signed-off-by: Soragna, Alberto <alberto.soragna@gmail.com>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
@wjwwood wjwwood force-pushed the alsora/fix_for_ipc branch from e07c1b8 to 71e5340 Compare October 18, 2019 23:56
@clalancette clalancette merged commit b099801 into ros2:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants