Merged
Conversation
Member
|
The change looks good at a glance. End of next week I'll create a package off the farm so we can test the fix out without waiting for a complete rebuild. |
Member
|
@dirk-thomas here's a package containing this change, installing it in a test container it sets the COLCON_PREFIX_PATH as expected and when I create a workspace on top of it and source its install/setup.bash it does appear to source the Crystal workspace too. ros-workspace-prerelease.tar.gz For anyone else who encounters this file, I cannot help you if this package destroys your computer. Do not trust it. |
nuclearsandwich
approved these changes
Feb 7, 2019
Member
nuclearsandwich
left a comment
There was a problem hiding this comment.
A package built against this patch appears to resolve the issue.
dirk-thomas
added a commit
that referenced
this pull request
Apr 29, 2019
This reverts commit 4f22f70.
dirk-thomas
added a commit
that referenced
this pull request
Apr 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for ros2/ros2#653.
connects to ros2/ros2#653