Skip to content

Add marshalling functions for rclpy.type_hash.TypeHash (rep2011)#816

Merged
clalancette merged 3 commits intoros2:rollingfrom
achim-k:achim-k/rep2011_type_hash
Jun 13, 2023
Merged

Add marshalling functions for rclpy.type_hash.TypeHash (rep2011)#816
clalancette merged 3 commits intoros2:rollingfrom
achim-k:achim-k/rep2011_type_hash

Conversation

@achim-k
Copy link
Copy Markdown
Contributor

@achim-k achim-k commented Apr 3, 2023

Part of ros2/ros2#1159

Depends on ros2/rclpy#1104

Features

  • Adds marshalling functions for rclpy.type_hash.TypeHash
  • Adapt comment that type hash is also printed when doing rostopic info --verbose

Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but this otherwise looks good.

@achim-k achim-k force-pushed the achim-k/rep2011_type_hash branch from 8d3d01a to e415470 Compare June 9, 2023 10:30
achim-k and others added 3 commits June 9, 2023 15:24
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
@achim-k achim-k force-pushed the achim-k/rep2011_type_hash branch from c658f12 to 92f560f Compare June 9, 2023 15:27
@clalancette
Copy link
Copy Markdown
Contributor

CI for this is in ros2/rclpy#1104 (comment)

@clalancette clalancette merged commit 960962a into ros2:rolling Jun 13, 2023
@clalancette
Copy link
Copy Markdown
Contributor

@Mergifyio backport iron

@mergify
Copy link
Copy Markdown

mergify bot commented Jun 13, 2023

backport iron

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jun 13, 2023
* Add marshalling functions for rclpy.type_hash.TypeHash

Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 960962a)
clalancette pushed a commit that referenced this pull request Jun 14, 2023
… (#835)

* Add marshalling functions for rclpy.type_hash.TypeHash

Signed-off-by: Hans-Joachim Krauch <achim.krauch@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 960962a)

Co-authored-by: Hans-Joachim Krauch <achim-k@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants