Add ros2 service info#771
Conversation
|
Running a full CI from (https://gist.github.com/mjcarroll/9e6d17c5e4b5b5ac9f9364365145277b) |
|
@mjcarroll friendly ping, could you renew CI ? |
|
@leeminju531 is this still draft? i am happy to review those PRs. |
|
friendly ping @audrow , I think my tasks are completed, are there more steps? |
|
@leeminju531 are you willing to implement this for https://github.com/ros2/rclcpp? about ros2/rmw#334 (comment), any thoughts? @audrow @gbiggs |
|
I think it would be useful to connect this to #703, which is my version of this feature. From my perspective it's important to have a version of this new verb which can be backported to Humble, since I'm working with commercial and industrial clients who can only use LTS releases of ROS 2. If a feature doesn't make it into an LTS release then these users will not be able to benefit from it until at least May 2024 when J-Turtle is released. It's a good approach to extend the fundamental Since the files you've added to
@leeminju531 what do you think? |
|
@schornakj it sounds reasonable to me 😊 |
|
It looks like this PR is still pending. |
|
@leeminju531 all related PRs look good to me except minor comments. i think it would be probably better to rebase all these PRs, and the we can start the CI. |
|
👌 All the things are addressed. @fujitatomoya |
|
@leeminju531 thanks for rebasing and addressing comments. CI: |
|
It looks like Windows is failing CI for some reason. @leeminju531 please take a look. |
|
passing next client count though, https://github.com/leeminju531/rmw_implementation/blob/59c7868449b283b38370d2e6c25aa9f3f94096ce/test_rmw_implementation/test/test_graph_api.cpp#L1007 probably we need to add some sleep to wait the graph update? |
|
I think adding a brief sleep can solve this too. I believe the failure can occur not only in Windows but in any operating system. The test attempts to discover the topic right after creating participants, so the time to discover was faster than its period. |
|
The sleep added in rmw_implementation. could you run CI again? @fujitatomoya |
|
@clalancette can you check ros2/rmw_implementation#208? once that is approved, i will start the CI again. |
|
@clalancette thanks for merging rmw packages. do you still need time for clients libraries including ros2cli? or i can start the CI based on the latest source. |
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
|
Thanks for merging all dependencies, Could someone run CI for this ? Additionally, I've considered the '--verbose' option for details like Nonetheless, it appears that information on which node owns the clients or services is possible here. In my experience, displaying this information seems to be quite useful. |
Related Issue #766
[DEPENDENCY] to track works related to this:
Anticipated output

Signed-off-by: leeminju531 dlalswn531@naver.com