Add rmw count clients services impl#93
Merged
clalancette merged 2 commits intoros2:rollingfrom Sep 29, 2023
leeminju531:rolling
Merged
Add rmw count clients services impl#93clalancette merged 2 commits intoros2:rollingfrom leeminju531:rolling
clalancette merged 2 commits intoros2:rollingfrom
leeminju531:rolling
Conversation
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
lgtm with https://github.com/ros2/rmw/pull/334/files#r1057986256 resolved.
Collaborator
|
CC: @asorbini |
Contributor
|
rmw interface changes have been merged Wait on |
asorbini
approved these changes
May 22, 2023
Collaborator
asorbini
left a comment
There was a problem hiding this comment.
Changes look good to me. They can be merged once ros2/rmw_implementation#208 is in. Thank you @leeminju531 for your contribution!
fujitatomoya
approved these changes
Sep 10, 2023
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Signed-off-by: leeminju531 <dlalswn531@naver.com>
Contributor
|
CI for this is in ros2/rmw_implementation#208 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is for service counts using it's name like topic.
Related to ros2/ros2cli#771
Signed-off-by: leeminju531 dlalswn531@naver.com