ros2 param dump/load should use fully qualified node names#600
Merged
ros2 param dump/load should use fully qualified node names#600
Conversation
Merged
audrow
approved these changes
Feb 19, 2021
Member
audrow
left a comment
There was a problem hiding this comment.
Nice minimal fix. Looks good to me with green CI.
Member
Author
|
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
f29273d to
53d4e1b
Compare
Member
Author
|
Not so minimal now 😬, but the test of |
Member
|
I'll take another look then. |
audrow
approved these changes
Feb 19, 2021
Member
|
I reran CI:
|
Member
Author
|
Thanks for the review @audrow ! |
v-lopez
pushed a commit
to pal-robotics-forks/ros2cli
that referenced
this pull request
Feb 23, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
added a commit
that referenced
this pull request
Mar 5, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
ros2 param dumpconsistent with howrclcppandrclpyload parameters.See for example https://github.com/ros2/rclcpp/blob/ab743392e4daf546eb0de704936b5f14ef6e0417/rclcpp/src/rclcpp/node_interfaces/node_parameters.cpp#L97.