Remove ros2interface test dependencies on builtin interface#579
Merged
Remove ros2interface test dependencies on builtin interface#579
Conversation
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
jacobperron
reviewed
Dec 17, 2020
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
703e512 to
3056860
Compare
Member
Author
|
I'm not sure why the PR job is failing, but here is CI.
|
jacobperron
reviewed
Dec 21, 2020
Member
jacobperron
left a comment
There was a problem hiding this comment.
LGTM (one minor comment)
We should also run CI and test the new package ros2cli_test_interfaces.
Member
|
I believe the PR job failure is the same as #577. It seems safe to ignore, since this change is only touching |
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
jacobperron
approved these changes
Dec 23, 2020
Member
Author
|
Here is a new CI. I am testing on
|
Member
Author
|
I reran windows. It seems to pass. I'll rebase on master and then rerun CI.
|
Member
I don't think rebasing is necessary when using a branch (instead of a repos file) for CI. |
Member
Author
|
This was referenced Jan 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #541 and is an alternative to the PRs associated with #547.
I think this is an important change because, as mentioned in ros2/system_tests#442 (comment), testing against these interface definitions allows us to cover behavior of
ros2 interface showthat is currently not covered, such as the bug fixed by #548. This PR also removes aros2interfacetest dependency onbuiltin_interfaces(#541).I've opted for this approach rather than the one used in #547 to avoid slowing down the test time and for simplicity. As @jacobperron mentions in ros2/test_interface_files#11 (comment) that adding these interfaces to may increase the time required for all of the tests to run. It also is much more complicated to add messages to
test_msgsas it requires PRs in four repositories.