[ros2interface] show "expanded" message definition#524
Merged
Conversation
Member
Author
|
sloretz
reviewed
Jun 3, 2020
Contributor
sloretz
left a comment
There was a problem hiding this comment.
Partial review.
While playing with it and the ROS 1 version, it seems like stripping comments and whitespace makes it a lot easier to read, which is what the ROS 1 version does.
Compare
$ ros2 interface show geometry_msgs/msg/TwistStamped
# A twist with reference coordinate frame and timestamp
std_msgs/Header header
# Standard metadata for higher-level stamped data types.
# This is generally used to communicate timestamped data
# in a particular coordinate frame.
# Two-integer timestamp that is expressed as seconds and nanoseconds.
builtin_interfaces/Time stamp
# Time indicates a specific point in time, relative to a clock's 0 point.
# The seconds component, valid over all int32 values.
int32 sec
# The nanoseconds component, valid in the range [0, 10e9).
uint32 nanosec
# Transform frame with which this data is associated.
string frame_id
Twist twist
# This expresses velocity in free space broken into its linear and angular parts.
Vector3 linear
# This represents a vector in free space.
# This is semantically different than a point.
# A vector is always anchored at the origin.
# When a transform is applied to a vector, only the rotational component is applied.
float64 x
float64 y
float64 z
Vector3 angular
# This represents a vector in free space.
# This is semantically different than a point.
# A vector is always anchored at the origin.
# When a transform is applied to a vector, only the rotational component is applied.
float64 x
float64 y
float64 zwith (manually stripped)
$ ros2 interface show geometry_msgs/msg/TwistStamped
std_msgs/Header header
builtin_interfaces/Time stamp
int32 sec
uint32 nanosec
string frame_id
Twist twist
Vector3 linear
float64 x
float64 y
float64 z
Vector3 angular
float64 x
float64 y
float64 z
Contributor
|
@audrow it looks like the |
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow <audrow.nash@gmail.com>
6ed1076 to
e76dccb
Compare
Member
Author
|
@sloretz I added the sign offs; thanks for pointing that out |
Signed-off-by: Audrow <audrow.nash@gmail.com>
Member
Author
|
@sloretz I agree that it will be nice to remove whitespace and comments. I can extend the current version, or do this in another PR. |
Signed-off-by: Audrow <audrow.nash@gmail.com>
Signed-off-by: Audrow <audrow.nash@gmail.com>
Contributor
Another PR works for me. When you open it, I would recommend making the whitespace and comment removed version the default behavior since it feels a lot easier to understand the output. @jacobperron since this repo has a |
sloretz
reviewed
Jun 4, 2020
Contributor
There was a problem hiding this comment.
LGTM with one nitpick, green CI, and confirmation from @jacobperron that it's ok to merge onto master.
Also, nice work with the recursive solution. It's a lot easier to understand.
Member
|
I've already created a |
Signed-off-by: Audrow <audrow.nash@gmail.com>
Member
Author
|
Signed-off-by: Audrow <audrow.nash@gmail.com>
craigh92
pushed a commit
to craigh92/ros2cli
that referenced
this pull request
Jun 11, 2020
* Expand interfaces with nesting in interface show Signed-off-by: Audrow <audrow.nash@gmail.com> * Make show interface not print anything on empty lines Signed-off-by: Audrow <audrow.nash@gmail.com> * Test nesting interface + update tests that used nested interfaces Signed-off-by: Audrow <audrow.nash@gmail.com> * Minor refactoring Signed-off-by: Audrow <audrow.nash@gmail.com> * Support arrays of expandable types Signed-off-by: Audrow <audrow.nash@gmail.com> * Yield file lines and use stack to organize nesting Signed-off-by: Audrow <audrow.nash@gmail.com> * Make member variable names and error text more consistent Signed-off-by: Audrow <audrow.nash@gmail.com> * Use str function to make TextLineInterface usage clearer Signed-off-by: Audrow <audrow.nash@gmail.com> * Simplify generator to get interface text lines Signed-off-by: Audrow <audrow.nash@gmail.com> * Reformat to pass flake-8 tests Signed-off-by: Audrow <audrow.nash@gmail.com> Signed-off-by: Craig <CraigUkaea@gmail.com>
craigh92
pushed a commit
to craigh92/ros2cli
that referenced
this pull request
Jun 11, 2020
* Expand interfaces with nesting in interface show Signed-off-by: Audrow <audrow.nash@gmail.com> * Make show interface not print anything on empty lines Signed-off-by: Audrow <audrow.nash@gmail.com> * Test nesting interface + update tests that used nested interfaces Signed-off-by: Audrow <audrow.nash@gmail.com> * Minor refactoring Signed-off-by: Audrow <audrow.nash@gmail.com> * Support arrays of expandable types Signed-off-by: Audrow <audrow.nash@gmail.com> * Yield file lines and use stack to organize nesting Signed-off-by: Audrow <audrow.nash@gmail.com> * Make member variable names and error text more consistent Signed-off-by: Audrow <audrow.nash@gmail.com> * Use str function to make TextLineInterface usage clearer Signed-off-by: Audrow <audrow.nash@gmail.com> * Simplify generator to get interface text lines Signed-off-by: Audrow <audrow.nash@gmail.com> * Reformat to pass flake-8 tests Signed-off-by: Audrow <audrow.nash@gmail.com> Signed-off-by: Craig <CraigUkaea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #348