[ros2interface] Remove usage of deprecated std_msgs and std_srvs packages#516
Merged
jacobperron merged 2 commits intomasterfrom May 22, 2020
Merged
[ros2interface] Remove usage of deprecated std_msgs and std_srvs packages#516jacobperron merged 2 commits intomasterfrom
jacobperron merged 2 commits intomasterfrom
Conversation
Member
Author
|
We should also consider removing/replacing usage in other ros2cli packages. |
dirk-thomas
reviewed
May 20, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
34e6891 to
bb2f5d3
Compare
hidmic
approved these changes
May 22, 2020
hidmic
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix @jacobperron !
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
wjwwood
approved these changes
May 22, 2020
craigh92
pushed a commit
to craigh92/ros2cli
that referenced
this pull request
Jun 11, 2020
…ages (ros2#516) Signed-off-by: Jacob Perron <jacob@openrobotics.org> Signed-off-by: Craig <CraigUkaea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages were deprecated in ros2/common_interfaces#116.
This also fixes a test failure introduced by the deprecation notice.