Skip to content

Deprecate ros2msg and ros2srv#363

Merged
jacobperron merged 3 commits intomasterfrom
jacob/deprecate_msg_srv
Oct 18, 2019
Merged

Deprecate ros2msg and ros2srv#363
jacobperron merged 3 commits intomasterfrom
jacob/deprecate_msg_srv

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Oct 16, 2019

Both packages have been superseded by ros2interface, which provides the same functionality
and more.

@jacobperron
Deprecate ros2msg and ros2srv
642b4d8 
Both packages have been superseded by ros2interface, which provides the same functionality
and more.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron added the in review Waiting for review (Kanban column) label Oct 16, 2019
@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Oct 16, 2019

If feasible maybe print the command to be used replacing the current invocation?

@hidmic hidmic mentioned this pull request Oct 16, 2019
Merged
@jacobperron
Add replacement command to deprecation warnings
b26a9c4 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Oct 16, 2019

If feasible maybe print the command to be used replacing the current invocation?

Good idea. Done in b26a9c4.

I'm not sure why, but the first part of the warning is repeated (I guess something to do with the stack trace). Not sure how to make it prettier, but I guess it's not a big deal, e.g.

$ ros2 srv show test_msgs/srv/Empty
/home/jacob/ws/ros2cli_ws/install/ros2srv/lib/python3.6/site-packages/ros2srv/verb/show.py:49: UserWarning: 'ros2 srv' is deprecated and will be removed in a future ROS release. Instead use: 'ros2 interface show test_msgs/srv/Empty.srv'
  "'ros2 srv' is deprecated and will be removed in a future ROS release. "
---

@mjcarroll
Copy link
Copy Markdown
Member

mjcarroll commented Oct 17, 2019

Epr doesn't seem to like the deprecated tag:

16:02:32 catkin_pkg.package.InvalidPackage: Error(s) in package '/tmp/ws/src/ros2cli/ros2srv/package.xml':
16:02:32 Error(s):
16:02:32 - The manifest of package "ros2srv" (with format version 2) must not contain the following tags: deprecated

mjcarroll
mjcarroll requested changes Oct 17, 2019
View reviewed changes
@jacobperron
Put deprecation tags inside export tags
c12af9f 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Oct 18, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 80921ce into master Oct 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/deprecate_msg_srv branch October 18, 2019 21:36
@jacobperron jacobperron mentioned this pull request Oct 19, 2019
Merged
@ghost ghost mentioned this pull request Oct 21, 2019
Closed
@jacobperron jacobperron mentioned this pull request Oct 21, 2019
Closed
@jacobperron jacobperron mentioned this pull request Nov 21, 2019
Merged
jacobperron added a commit that referenced this pull request Dec 2, 2019
@jacobperron
[ros2action] Deprecate show verb
035560e 
This is a follow-up to #363, as we've consolidated interface CLI logic to ros2interface.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request Dec 2, 2019
Merged
jacobperron added a commit that referenced this pull request Dec 3, 2019
@jacobperron
[eloquent] [ros2action] Deprecate show verb (#413)
38a5552 
* [ros2action] Deprecate show verb

This is a follow-up to #363, as we've consolidated interface CLI logic to ros2interface.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Update tests to pass

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees

No one assigned

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobperron @dirk-thomas @mjcarroll