Change action_tutorials_py for action_tutorials_cpp#315
Merged
Conversation
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Member
Author
|
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Member
Author
|
hidmic
approved these changes
Aug 13, 2019
hidmic
left a comment
There was a problem hiding this comment.
LGTM but yes, we really need to dig into the issue with Python action servers.
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Load composable nodes in sequence Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Undo whitespace change Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #313.
For a reason I don't understand, after we split
action_tutorialsinaction_tutorials_pyandaction_tutorials_interfaces, launch_testing can't killfibonacci_action_serverand the test fails (before we were installing a script and running it withpython .... Now we are installing it using console scripts entry points, that already installs an executable).I switched to
action_tutorials_cppexecutable and it works well now.I will dig in the real problem later, this is just for having green CI.