Conversation
dirk-thomas
approved these changes
Jan 31, 2019
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
d8c53f0 to
6ebf9a6
Compare
Contributor
Author
|
CI (launch, ros2topic, ament_pyflakes) including ros2/launch#169
|
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* Add normalize_parameters and evaluate_paramters Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Misc mypy complaint fixes Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * More mypy appeasement Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * fix bugs introduced whil appeasing mypy Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Another mypy complaint fixed Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * fix checking str and substitution Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Avoid indentation Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * keys -> key Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * substututions -> substitutions Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add test with float as first element in numeric list Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add test with string before substitution Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * Add more dissimilar tests and fix bugs Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> * SomeParameterValue multi value substitutions Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failures in nightly_linux-aarch64_debug #713, nightly_linux-aarch64_extra_rmw_release #245, nightly_linux-aarch64_release #673, nightly_linux_debug #1088, nightly_linux_extra_rmw_release #241, nightly_linux_release #1069, nightly_osx_debug #1143, nightly_osx_extra_rmw_release #279, nightly_osx_release #1151, nightly_win_deb #1143, nightly_win_extra_rmw_rel #248, nightly_win_rel #1082, nightly_xenial_linux-aarch64_release #243, nightly_xenial_linux_release #234
More PRs coming shortly