[topic pub] add option to limit printing published msgs#123
Merged
dirk-thomas merged 2 commits intomasterfrom Jul 12, 2018
Merged
[topic pub] add option to limit printing published msgs#123dirk-thomas merged 2 commits intomasterfrom
dirk-thomas merged 2 commits intomasterfrom
Conversation
Member
|
as this has low risk of regression and taking it will allow us to fast-forward bouncy to the current state of master; I'm planning on integrating this to the bouncy patch release |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
…#123) * add self descriptions for substitutions * add tracebacks back to the output by default * add new actions for declaring launch arguments * new method on LaunchDescription which gets all declared arguments within * add ability to pass arguments when including a launch description * add description for local variables used in Node action * fix bug in Node action * cleanup error reporting in Node action * use launch arguments in examples * add ability to show and pass launch arguments on the command line * fix python 3.5 support * add accessor for the Condition of an Action Signed-off-by: William Woodall <william@osrfoundation.org> * do not automatically push/pop configs when including Signed-off-by: William Woodall <william@osrfoundation.org> * small refactor to get the launch file location Signed-off-by: William Woodall <william@osrfoundation.org> * improve ability to detect declared arguments across launch file includes Signed-off-by: William Woodall <william@osrfoundation.org> * add tests for the new DeclareLaunchArgument action Signed-off-by: William Woodall <william@osrfoundation.org> * test new features of IncludeLaunchDescription Signed-off-by: William Woodall <william@osrfoundation.org> * test new features of LaunchDescription class Signed-off-by: William Woodall <william@osrfoundation.org> * remove unused imports Signed-off-by: William Woodall <william@osrfoundation.org> * improve output when showing arguments of a launch file Signed-off-by: William Woodall <william@osrfoundation.org> * fix the return type of LaunchService.run() Signed-off-by: William Woodall <william@osrfoundation.org> * fix the checking for the asyncio event loop for the case where it is not set Signed-off-by: William Woodall <william@osrfoundation.org> * typo Signed-off-by: William Woodall <william@osrfoundation.org> * restart event loop to allow proper shutdown when there's an unhandled exception Signed-off-by: William Woodall <william@osrfoundation.org> * ExecuteProcess: unregister event handlers if rest of setup fails The event handlers need to be setup before the other lines, but are invalid if setup does not complete successfully. * only put traceback in debug logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself patching the code several times when I wanted to publish messages with a higher rate but without the overhead of flooding the console (which essentially slows down the loop). Hence the first commit adds an option to control how many published message should be printed (e.g. try
-r 1000 -p 250).The second commit only removes a default value which doesn't make sense. The default node name is not as indicated and empty string but is being set by the script later if no not-empty node name is provided.