Merged
Conversation
This allows to raise with an appropriate error message if the default rmw implementation is not installed on the system
dirk-thomas
approved these changes
Jul 5, 2018
This was referenced Jul 13, 2018
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
* add Condition class and use in Action class * add If and Unless Conditions which use Substitutions * update actions to pass through condition arguments to Action base class * fixup type annotations in ExecuteProcess action * fixup architecture doc * address flake8 failure that doesn't show locally for me
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
The example should not be using the underlying launch_ros ROS context or ROS node since it is an implementation detail. Instead, the example initailizes it's own context and ROS node. Fixes ros2#97. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for #120
without the patch:
with the patch: