Skip to content

Enable RMW isolation for ros2doctor.test_report.#1096

Closed
fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya/rmw-isolation-for-test_report
Closed

Enable RMW isolation for ros2doctor.test_report.#1096
fujitatomoya wants to merge 2 commits intorollingfrom
fujitatomoya/rmw-isolation-for-test_report

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Sep 4, 2025

Description

This should have aligned with #1062

Fixes # (issue)

I am not fully sure but this could be related to #1088

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

fujitatomoya
fujitatomoya commented Sep 4, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was just missing from #1062.

with my local environment, colcon test --event-handlers console_direct+ --packages-select ros2doctor now passes.

@fujitatomoya fujitatomoya mentioned this pull request Sep 4, 2025
Closed
@fujitatomoya
Enable RMW isolation for ros2doctor.test_report.
022fe15 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/rmw-isolation-for-test_report branch from e2f3bc0 to 022fe15 Compare September 4, 2025 08:07
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 4, 2025

Pulls: #1096
Gist: https://gist.githubusercontent.com/fujitatomoya/e0c83195f9fa9a4ece8b476a8ee0b862/raw/c3dc70b58df2eb44fd377e8292a8061184fd90d3/ros2.repos
BUILD args: --packages-up-to ros2doctor
TEST args: --packages-select ros2doctor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16847

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya self-assigned this Sep 4, 2025
@fujitatomoya fujitatomoya added the bug Something isn't working label Sep 4, 2025
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 4, 2025

@ahcorde thanks for the review.

although this is the correct fix, unfortunately this does not fix the #1088.

see https://ci.ros2.org/job/ci_linux-aarch64/18786/testReport/junit/ros2doctor.ros2doctor.test/test_qos_compatibility/test_qos_compatibility/ and https://ci.ros2.org/job/ci_linux-aarch64/18786/testReport/junit/ros2doctor.ros2doctor.test/test_report/test_report/

@fujitatomoya
ResetEnvironment on shutdown is missing.
3247d58 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 4, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Sep 4, 2025
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 4, 2025

i will go ahead to close this PR, because #1098 includes this patch as well.

@christophebedard christophebedard deleted the fujitatomoya/rmw-isolation-for-test_report branch September 4, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@cottsay cottsay Awaiting requested review from cottsay

@christophebedard christophebedard Awaiting requested review from christophebedard

Assignees

@fujitatomoya fujitatomoya

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fujitatomoya @ahcorde