Skip to content

Cross-Vendor communication is not guaranteed by design.#4736

Merged
clalancette merged 2 commits intorollingfrom
fujitatomoya/cross-vendor-communication-note
Sep 23, 2024
Merged

Cross-Vendor communication is not guaranteed by design.#4736
clalancette merged 2 commits intorollingfrom
fujitatomoya/cross-vendor-communication-note

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya commented Sep 12, 2024

closes ros2/ros2cli#586 and #3288

@fujitatomoya
Cross-Vendor communication is not guaranteed by design.
1cf0055 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya self-assigned this Sep 12, 2024
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 12, 2024

@clalancette @wjwwood @mjcarroll @alsora @ahcorde what do you think? I think at lease we can provide the information like this for now.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 12, 2024 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10985434098/artifacts/1963988524.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4736/index.html in your favorite browser

alsora
alsora approved these changes Sep 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@alsora alsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with adding this.

@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

fujitatomoya commented Sep 13, 2024

@alsora @ahcorde thanks for the approval.

@clalancette what do you think? if i remember correctly, we have talked about this long time before, and there was no clear decision. we knew that this is frowned upon, but did not want to explicitly note this? just checking, please let me know your thoughts.

clalancette
clalancette requested changes Sep 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of adding in a note. I've rewritten it in my suggestion; what do you think?

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 21, 2024
@fujitatomoya
rewrite the description from review.
f2bfb2b 
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@clalancette clalancette merged commit 355ed2c into rolling Sep 23, 2024
@clalancette clalancette deleted the fujitatomoya/cross-vendor-communication-note branch September 23, 2024 00:52
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@fujitatomoya @mergify
Cross-Vendor communication is not guaranteed by design. (#4736)
db4fb9e 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
@mergify mergify bot mentioned this pull request Sep 23, 2024
Merged
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@fujitatomoya @mergify
Cross-Vendor communication is not guaranteed by design. (#4736)
12792e5 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
@fujitatomoya @mergify
Cross-Vendor communication is not guaranteed by design. (#4736)
d81d3af 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
This was referenced Sep 23, 2024
Merged
Merged
clalancette pushed a commit that referenced this pull request Sep 23, 2024
@mergify @fujitatomoya
Cross-Vendor communication is not guaranteed by design. (#4736) (#4768)
1c588c4 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Sep 23, 2024
@mergify @fujitatomoya
Cross-Vendor communication is not guaranteed by design. (#4736) (#4770)
a8a2032 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Sep 23, 2024
@mergify @fujitatomoya
Cross-Vendor communication is not guaranteed by design. (#4736) (#4769)
128440d 
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This was referenced Sep 23, 2024
Closed
Closed
@ros-discourse
Copy link
Copy Markdown

ros-discourse commented May 15, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/incompatability-between-distributions/43747/11

@christophebedard christophebedard mentioned this pull request May 20, 2025
Merged
@mergify mergify bot mentioned this pull request May 20, 2025
Merged
This was referenced May 20, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@ahcorde ahcorde ahcorde approved these changes

@alsora alsora alsora approved these changes

@audrow audrow Awaiting requested review from audrow

Assignees

@fujitatomoya fujitatomoya

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ros2 param list does not work with multiple rmw implementaion

5 participants

@fujitatomoya @ros-discourse @clalancette @ahcorde @alsora