add ros2 service echo beginners CLI and Service Introspection demo.#4199
Merged
fujitatomoya merged 3 commits intorollingfrom Mar 4, 2024
Merged
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
fujitatomoya
commented
Mar 3, 2024
Collaborator
Author
fujitatomoya
left a comment
There was a problem hiding this comment.
@clalancette @Yadunund can you take a look?
This was referenced Mar 3, 2024
Yadunund
approved these changes
Mar 3, 2024
Member
Yadunund
left a comment
There was a problem hiding this comment.
This is a very valuable addition to the tutorials! Thanks a lot Tomoya! Left some minor nitpicks to consider.
source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Services/Understanding-ROS2-Services.rst
Show resolved
Hide resolved
source/Tutorials/Beginner-CLI-Tools/Understanding-ROS2-Services/Understanding-ROS2-Services.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Collaborator
Author
|
@Yadunund thanks for the review! |
Collaborator
Author
|
@Mergifyio backport iron |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…#4199) * add `ros2 service echo` beginners CLI tutorial. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * add Service Introspection tutorial. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * review comments update. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> --------- Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit a07196c)
clalancette
pushed a commit
that referenced
this pull request
Mar 4, 2024
…#4199) (#4202) * add `ros2 service echo` beginners CLI tutorial. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * add Service Introspection tutorial. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> * review comments update. Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> --------- Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> (cherry picked from commit a07196c) Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to close ros2/ros2#1285 and replace #2981