Skip to content

Add a release note about removed rclcpp subscription signatures.#4185

Merged
clalancette merged 1 commit intorollingfrom
clalancette/deprecated-signatures
Feb 23, 2024
Merged

Add a release note about removed rclcpp subscription signatures.#4185
clalancette merged 1 commit intorollingfrom
clalancette/deprecated-signatures

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

This goes along with ros2/rclcpp#2431

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette requested a review from audrow as a code owner February 23, 2024 02:56
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Feb 23, 2024
Copy link
Copy Markdown
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the Humble release notes to double check and found no mention of this, but the code does check out.

@clalancette clalancette merged commit cb90370 into rolling Feb 23, 2024
@delete-merged-branch delete-merged-branch bot deleted the clalancette/deprecated-signatures branch February 23, 2024 12:50
mergify bot pushed a commit that referenced this pull request Feb 23, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit cb90370)
mergify bot pushed a commit that referenced this pull request Feb 23, 2024
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit cb90370)
clalancette added a commit that referenced this pull request Feb 23, 2024
…) (#4186)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit cb90370)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request Feb 23, 2024
…) (#4187)

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit cb90370)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants