Skip to content

First pass at the Iron Irwini release notes.#3395

Merged
clalancette merged 4 commits intorollingfrom
clalancette/add-iron-complete-changelog
Mar 24, 2023
Merged

First pass at the Iron Irwini release notes.#3395
clalancette merged 4 commits intorollingfrom
clalancette/add-iron-complete-changelog

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

That is, add in the full changelog, and also greatly expand the release notes themselves.

I should point out that the full changelog is necessarily not complete; it only contains information on things that have already been released.

The release note page is a cut-down version of the full changelog that just has things that might be interesting to end users. What is currently in there was my opinion, so this list may be expanded or reduced based on thoughts from other people.

In both cases, we should be able to iteratively add new items here as they are landed.

@clalancette clalancette requested a review from Yadunund March 22, 2023 19:36
@clalancette clalancette requested a review from audrow as a code owner March 22, 2023 19:36
@christophebedard
Copy link
Copy Markdown
Member

I feel like the list of contributors under each package doesn't really match the list of contributors in the package's CHANGELOG file. For example, the aggregated release notes for tracetools combine the release notes from 5.0.0 and 5.1.0 but only use the contributors from 5.0.0.

@clalancette
Copy link
Copy Markdown
Contributor Author

I feel like the list of contributors under each package doesn't really match the list of contributors in the package's CHANGELOG file. For example, the aggregated release notes for tracetools combine the release notes from 5.0.0 and 5.1.0 but only use the contributors from 5.0.0.

Huh, good point. There must be a bug in the script I use to generate this; I'll take a look.

Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette I will add the note for

i save the reminders for each issue about this task not to miss.

@clalancette
Copy link
Copy Markdown
Contributor Author

i save the reminders for each issue about this task not to miss.

Great, thanks @fujitatomoya .

clalancette and others added 3 commits March 22, 2023 17:29
That is, add in the full changelog, and also greatly
expand the release notes themselves.

I should point out that the full changelog is necessarily
*not* complete; it only contains information on things that
have already been released.

The release note page is a cut-down version of the full
changelog that just has things that might be interesting
to end users.  What is currently in there was my opinion,
so this list may be expanded or reduced based on thoughts
from other people.

In both cases, we should be able to iteratively add new
items here as they are landed.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>

Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
As pointed out by Christophe Bedard, there were some
people missing from the Contributors.  After doing some
work on the script in https://github.com/clalancette/ros_changelog_from_pkgs,
this is the update.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette clalancette force-pushed the clalancette/add-iron-complete-changelog branch from a5330b2 to f104dee Compare March 22, 2023 21:41
@clalancette
Copy link
Copy Markdown
Contributor Author

I feel like the list of contributors under each package doesn't really match the list of contributors in the package's CHANGELOG file. For example, the aggregated release notes for tracetools combine the release notes from 5.0.0 and 5.1.0 but only use the contributors from 5.0.0.

@christophebedard Based on this comment, I fixed some bugs in the script I use to generate this (https://github.com/clalancette/ros_changelog_from_pkgs). The latest commit adds in the new output, and at least for the repositories I spot-checked, added in the missing Contributors. Tomorrow I'll do a more thorough check, but thanks for diligently checking!

@clalancette
Copy link
Copy Markdown
Contributor Author

All right. I didn't exhaustively go over every package (there are 350 of them), but I did a more thorough spot-check and the contributor list looks good on every package I checked. So I'm pretty happy with this.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Copy link
Copy Markdown
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final set of comments from my side!

Copy link
Copy Markdown
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for putting this together 🙇🏼

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Mar 24, 2023
@clalancette clalancette merged commit 1be681d into rolling Mar 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/add-iron-complete-changelog branch March 24, 2023 18:22
mergify bot pushed a commit that referenced this pull request Mar 24, 2023
* First pass at the Iron Irwini release notes.

That is, add in the full changelog, and also greatly
expand the release notes themselves.

I should point out that the full changelog is necessarily
*not* complete; it only contains information on things that
have already been released.

The release note page is a cut-down version of the full
changelog that just has things that might be interesting
to end users.  What is currently in there was my opinion,
so this list may be expanded or reduced based on thoughts
from other people.

In both cases, we should be able to iteratively add new
items here as they are landed.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 1be681d)
mergify bot pushed a commit that referenced this pull request Mar 24, 2023
* First pass at the Iron Irwini release notes.

That is, add in the full changelog, and also greatly
expand the release notes themselves.

I should point out that the full changelog is necessarily
*not* complete; it only contains information on things that
have already been released.

The release note page is a cut-down version of the full
changelog that just has things that might be interesting
to end users.  What is currently in there was my opinion,
so this list may be expanded or reduced based on thoughts
from other people.

In both cases, we should be able to iteratively add new
items here as they are landed.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 1be681d)
clalancette added a commit that referenced this pull request Mar 24, 2023
* First pass at the Iron Irwini release notes.

That is, add in the full changelog, and also greatly
expand the release notes themselves.

I should point out that the full changelog is necessarily
*not* complete; it only contains information on things that
have already been released.

The release note page is a cut-down version of the full
changelog that just has things that might be interesting
to end users.  What is currently in there was my opinion,
so this list may be expanded or reduced based on thoughts
from other people.

In both cases, we should be able to iteratively add new
items here as they are landed.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 1be681d)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
clalancette added a commit that referenced this pull request Mar 24, 2023
* First pass at the Iron Irwini release notes.

That is, add in the full changelog, and also greatly
expand the release notes themselves.

I should point out that the full changelog is necessarily
*not* complete; it only contains information on things that
have already been released.

The release note page is a cut-down version of the full
changelog that just has things that might be interesting
to end users.  What is currently in there was my opinion,
so this list may be expanded or reduced based on thoughts
from other people.

In both cases, we should be able to iteratively add new
items here as they are landed.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Co-authored-by: G.A. vd. Hoorn <g.a.vanderhoorn@tudelft.nl>
(cherry picked from commit 1be681d)

Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all backport at reviewers discretion; from rolling to all versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants