Update Building-a-Visual-Robot-Model-with-URDF-from-Scratch.rst#3071
Merged
clalancette merged 1 commit intoros2:humblefrom Oct 3, 2022
Merged
Update Building-a-Visual-Robot-Model-with-URDF-from-Scratch.rst#3071clalancette merged 1 commit intoros2:humblefrom
clalancette merged 1 commit intoros2:humblefrom
Conversation
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary
clalancette
approved these changes
Oct 3, 2022
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Yes, you are right. This should have been fixed long ago, though it is honestly not that easy for me to test it out. That said, I think we should go ahead with this and we'll see if anyone complains.
Contributor
|
@Mergifyio backport rolling foxy galactic |
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948)
This was referenced Oct 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948)
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948)
clalancette
pushed a commit
that referenced
this pull request
Oct 3, 2022
… (#3072) I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948) Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Oct 3, 2022
… (#3073) I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948) Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
clalancette
pushed a commit
that referenced
this pull request
Oct 3, 2022
… (#3074) I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary (cherry picked from commit 611f948) Co-authored-by: Matthew Elwin <10161574+m-elwin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the bug with respect to locale was fixed a while back ros/urdfdom_headers#42 so setting LC_NUMERIC is no longer necessary