Skip to content

Note launch behavior change in Foxy Patch 7#2074

Merged
jacobperron merged 3 commits intorollingfrom
jacob/foxy_patch_7_notes
Feb 7, 2022
Merged

Note launch behavior change in Foxy Patch 7#2074
jacobperron merged 3 commits intorollingfrom
jacob/foxy_patch_7_notes

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@jacobperron jacobperron commented Oct 26, 2021

@jacobperron jacobperron requested a review from ivanpauno October 26, 2021 22:46
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Oct 26, 2021

IIUC, this release page is not hosted in a distro-specific manner so we should target rolling and backport to foxy and galactic branches. Is this correct, @clalancette?

@jacobperron jacobperron mentioned this pull request Oct 26, 2021
Merged
@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Oct 27, 2021

IIUC, this release page is not hosted in a distro-specific manner so we should target rolling and backport to foxy and galactic branches. Is this correct, @clalancette?

Yes, that's correct. Right now, the release notes for all distributions is hosted on all branches. What you've done here is exactly correct (I also added the labels so that Mergify will backport this to Foxy and Galactic).

jacobperron and others added 3 commits October 26, 2021 21:30
@jacobperron @clalancette
Note launch behavior change in Foxy Patch 7
0490797 
Related to ros2/launch#530 and ros2/launch_ros#265

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron @clalancette
Fix link syntax
e9f0c15 
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@clalancette
Minor fixes.
c03c993 
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
@clalancette clalancette force-pushed the jacob/foxy_patch_7_notes branch from 07ba00e to c03c993 Compare October 27, 2021 01:33
clalancette
clalancette approved these changes Oct 27, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I rebased this onto the latest and made some minor fixes to the XML and spelling. From my perspective, this is ready to go. @jacobperron feel free to merge this when you are ready with the patch release.

@jacobperron jacobperron merged commit dc0ddb4 into rolling Feb 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/foxy_patch_7_notes branch February 7, 2022 19:07
mergify bot pushed a commit that referenced this pull request Feb 7, 2022
@jacobperron @clalancette
Note launch behavior change in Foxy Patch 7 (#2074)
fd90473 
* Note launch behavior change in Foxy Patch 7

Related to ros2/launch#530 and ros2/launch_ros#265

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix link syntax

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Minor fixes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit dc0ddb4)
@mergify mergify bot mentioned this pull request Feb 7, 2022
Closed
mergify bot pushed a commit that referenced this pull request Feb 7, 2022
@jacobperron @clalancette
Note launch behavior change in Foxy Patch 7 (#2074)
0b2af67 
* Note launch behavior change in Foxy Patch 7

Related to ros2/launch#530 and ros2/launch_ros#265

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Fix link syntax

Signed-off-by: Jacob Perron <jacob@openrobotics.org>

* Minor fixes.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
(cherry picked from commit dc0ddb4)
@mergify mergify bot mentioned this pull request Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@jacobperron jacobperron

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacobperron @clalancette @ivanpauno