Add Note about rosidl_target_interfaces deprecation in Humble#1798
Merged
Add Note about rosidl_target_interfaces deprecation in Humble#1798
Conversation
clalancette
previously requested changes
Aug 4, 2021
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
clalancette
approved these changes
Aug 4, 2021
audrow
approved these changes
Aug 4, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Add rosidl_target_interfaces deprecation * Apply suggestions from code review Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * Add link to ros2/demos#529 for an example Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit fe025df)
mergify bot
pushed a commit
that referenced
this pull request
Aug 4, 2021
* Add rosidl_target_interfaces deprecation * Apply suggestions from code review Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * Add link to ros2/demos#529 for an example Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit fe025df)
clalancette
pushed a commit
that referenced
this pull request
Aug 5, 2021
…#1799) * Add rosidl_target_interfaces deprecation * Apply suggestions from code review Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * Add link to ros2/demos#529 for an example Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit fe025df) Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
clalancette
pushed a commit
that referenced
this pull request
Aug 5, 2021
…#1800) * Add rosidl_target_interfaces deprecation * Apply suggestions from code review Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> * Add link to ros2/demos#529 for an example Signed-off-by: Shane Loretz <sloretz@osrfoundation.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org> (cherry picked from commit fe025df) Co-authored-by: Shane Loretz <sloretz@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rosidl#606
I also fixed a markdown code block to be an RST code block instead, but I'm happy to move that to a different PR