Skip to content

switch to Fast-RTPS 2.0.x#906

Merged
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/fastrtps-2.0.x
Apr 27, 2020
Merged

switch to Fast-RTPS 2.0.x#906
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/fastrtps-2.0.x

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas commented Apr 22, 2020 •
edited
Loading

Full CI builds with only Fast-RTPS:

  • Linux Build Status
    • Unrelated CMake warning
  • Linux-aarch64 Build Status
    • Unrelated CMake warning
  • macOS Build Status
    • Unrelated CMake warning
  • Windows Build Status
    • Unrelated compiler warnings
    • 112 test failures, some might be "expected" if they happened with 1.10.x already, but certainly not all

@dirk-thomas dirk-thomas self-assigned this Apr 22, 2020
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Apr 22, 2020

Waiting for results of this before merging ros2/rmw_fastrtps#362

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Apr 24, 2020

@JaimeMartin @MiguelCompany Please investigate the above test failures (112 on Windows, some might be known/expected but this scale of failures is certainly not) and resolve asap.

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas commented Apr 27, 2020

Windows build (after upstream disabled shared memory on Windows): Build Status

@nuclearsandwich nuclearsandwich mentioned this pull request Apr 27, 2020
Merged
@dirk-thomas dirk-thomas requested a review from jacobperron April 27, 2020 21:29
jacobperron
jacobperron approved these changes Apr 27, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The failures in the Windows job look like they are already occurring on our nightly.

@dirk-thomas dirk-thomas merged commit c7c115a into master Apr 27, 2020
@sloretz sloretz mentioned this pull request Apr 27, 2020
Merged
@dirk-thomas dirk-thomas deleted the dirk-thomas/fastrtps-2.0.x branch April 27, 2020 21:44
ivanpauno added a commit that referenced this pull request Apr 28, 2020
@ivanpauno
Revert "switch to Fast-RTPS 2.0.x (#906)"
68bcf6d 
This reverts commit c7c115a.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno mentioned this pull request Apr 28, 2020
Closed
@sloretz
Copy link
Copy Markdown
Contributor

sloretz commented Apr 28, 2020 •
edited
Loading

It appears many of last night's test failures can be attributed to this PR bumping the Fast-RTPS version (400 new failures in nightly_linux_debug) which then caused cross-vendor tests in test_communication to fail. It looks like it was missed here because CI here was limited to Fast-RTPS. I think the lesson that can be learned from this is to use the normal set of rmw implementations (or at least the Tier 1 ones) when running CI for Fast-RTPS branch changes (or maybe any rmw implementation changes), but of course hindsight is 20/20.

Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
@dirk-thomas
switch to Fast-RTPS 2.0.x (ros2#906)
023b877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobperron jacobperron jacobperron approved these changes

Assignees

@dirk-thomas dirk-thomas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirk-thomas @sloretz @jacobperron