Skip to content

Add new split repositories#515

Merged
nuclearsandwich merged 1 commit intomasterfrom
repository-splitting
Jun 23, 2018
Merged

Add new split repositories#515
nuclearsandwich merged 1 commit intomasterfrom
repository-splitting

Conversation

@nuclearsandwich
Copy link
Copy Markdown
Member

@nuclearsandwich nuclearsandwich commented Jun 22, 2018

The following changes are being enacted in order to break a repository level dependency cycle.

  • rosidl:
    • python_cmake_module (moved to rosidl_generator_py)
    • rosidl_cmake
    • rosidl_generator_c
    • rosidl_generator_cpp
    • rosidl_generator_py (moved to rosidl_generator_py)
    • rosidl_parser
    • rosidl_typesupport_interface
    • rosidl_typesupport_introspection_c
    • rosidl_typesupport_introspection_cpp
  • rmw:
    • rmw
    • rmw_implementation_cmake
  • rosidl_typesupport_connext:
    • connext_cmake_module (moved from rmw_connext)
    • rosidl_typesupport_connext_c (moved from rmw_connext)
    • rosidl_typesupport_connext_cpp (moved from rmw_connext)
  • rosidl_typesupport_opensplice:
    • opensplice_cmake_module (moved from rmw_opensplice)
    • rosidl_typesupport_opensplice_c (moved from rmw_opensplice)
    • rosidl_typesupport_opensplice_cpp (moved_from rmw_opensplice)
  • rosidl_typesupport:
    • rosidl_default_generators (moved to rosidl_default)
    • rosidl_default_runtime (moved to rosidl_default)
    • rosidl_typesupport_c
    • rosidl_typesupport_cpp
  • rmw_connext:
    • connext_cmake_module (moved to connext_typesupport
    • rmw_connext_cpp
    • rmw_connext_dynamic_cpp
    • rmw_connext_shared_cpp
    • rosidl_typesupport_connext_c (moved to connext_typesupport)
    • rosidl_typesupport_connext_cpp (moved to connext_typesupport)
  • rmw_fastrtps:
    • fastrtps_cmake_module
    • rmw_fastrtps_cpp
  • rmw_opensplice:
    • opensplice_cmake_module (moved to opensplice_typesupport)
    • rmw_opensplice_cpp
    • rosidl_typesupport_opensplice_c (moved to opensplice_typesupport)
    • rosidl_typesupport_opensplice_cpp (moved to opensplice_typesupport)
  • rmw_implementation:
    • rmw_implementation
  • rosidl_python:
    • python_cmake_module (moved from rosidl)
    • rosidl_generator_py (moved from rosidl)
  • rosidl_defaults:
    • rosidl_default_generator (moved from rosidl_typesupport)
    • rosidl_default_runtime (moved from rosidl_typesupport)

@nuclearsandwich nuclearsandwich added the in progress Actively being worked on (Kanban column) label Jun 22, 2018
@nuclearsandwich nuclearsandwich self-assigned this Jun 22, 2018
This was referenced Jun 22, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nuclearsandwich
Copy link
Copy Markdown
Member Author

nuclearsandwich commented Jun 22, 2018 •
edited
Loading

@nuclearsandwich nuclearsandwich added in review Waiting for review (Kanban column) and removed in progress Actively being worked on (Kanban column) labels Jun 22, 2018
@wjwwood
Copy link
Copy Markdown
Member

wjwwood commented Jun 22, 2018

/cc @dejanpan these are the new repositories I was talking about.

@dirk-thomas
Copy link
Copy Markdown
Member

dirk-thomas commented Jun 23, 2018

I disabled wikis and projects on the new repos.

dirk-thomas
dirk-thomas approved these changes Jun 23, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@dirk-thomas dirk-thomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (including the referenced PRs)

Better move forward and follow up on problems then waiting...

@nuclearsandwich nuclearsandwich merged commit 9d47251 into master Jun 23, 2018
@nuclearsandwich nuclearsandwich removed the in review Waiting for review (Kanban column) label Jun 23, 2018
@nuclearsandwich nuclearsandwich deleted the repository-splitting branch June 23, 2018 12:55
@dejanpan
Copy link
Copy Markdown

dejanpan commented Jun 29, 2018

@nuclearsandwich @dirk-thomas the list of above changes looks really big at the first glance.

Do you guys have some text somewhere why this change was needed?

@mikaelarguedas
Copy link
Copy Markdown
Member

mikaelarguedas commented Jun 29, 2018

@dejanpan while this look like a big change, there is actually no code change associated with this splitting. This is only a matter of relocating packages.

When preparing the bouncy release we noticed that several repositories (not packages just repositories) had circular dependencies. While this isn't an issue on the software side or at the package level, it doesn't play well with our release infrastructure and tools that operate on a per repository basis (rather than a per package basis).
Splitting these repositories was required to be able to release debs for Bouncy without a lot of manual steps and temporary failing builds.

This was referenced Jul 31, 2018
Merged
Closed
Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
@nuclearsandwich
Split repositories to break cyclic dependencies. (ros2#515)
b91a170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nuclearsandwich nuclearsandwich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nuclearsandwich @wjwwood @dirk-thomas @dejanpan @mikaelarguedas