use Fast-RTPS branch with fixed namespaces#482
Merged
mikaelarguedas merged 1 commit intomasterfrom Apr 16, 2018
Merged
Conversation
dirk-thomas
approved these changes
Apr 16, 2018
Member
Author
|
Merging to fix the build, I'll monitor Fast-RTPS to revert this as soon as it's merged on their side |
Jiusi-pys
pushed a commit
to Jiusi-pys/ros2
that referenced
this pull request
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ros2/rmw_fastrtps#196 broke the windows builds
Point to the Fast-RTPS branch with fixed namespaces pending it being merged in master.
MSVC is not happy with the ambiguity of our
usingdirective and the globalusing namespacein Fast-RTPS headers.Current build failure:
With this fix up to rmw_fastrtps_cpp:
All stack (just in case):