Move geometry2 (both locally, and on github).#324
Conversation
We want to switch to using our fork, instead of a branch on the original. This matches what we do for other repositories. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
ros2.repos
Outdated
| url: https://github.com/ros/class_loader.git | ||
| version: ros2 | ||
| ros/geometry2: | ||
| ros2/geometry2: |
There was a problem hiding this comment.
Nit: should be placed alphabetically in the list
There was a problem hiding this comment.
Whoops. Done now.
Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
|
do we have a standard yet for how we organise ported ros1-to-ros2 repos in this file? Was |
|
I think the logic was the folder name matches the org unit it's pulled from. But that's actually a guess based on observations, I don't know if we have a standard for that. It could make sense to dissociate the core of ros2 from the packages ported from ros1, at the folder level and even maybe at the org unit level |
|
OK it's fine by me to match the org unit for now and we can always change it in the future if it makes more sense to have a different structure for ported packages 👍 |
|
Thanks all, merged now. I think this won't happen automatically for people; should I send out a notification somewhere that the location has changed? |
|
Any change to the repos file will require people to pull the new one and import it in their workspace. You are right that people already having geometry2 in their workspace will have a hiccup of duplicate packages (ament will notify the duplication and the location of the conflicting packages). |
* Move geometry2 (both locally, and on github). We want to switch to using our fork, instead of a branch on the original. This matches what we do for other repositories. Signed-off-by: Chris Lalancette <clalancette@osrfoundation.org>
We want to switch to using our fork, instead of a branch on
the original. This matches what we do for other repositories.
Signed-off-by: Chris Lalancette clalancette@osrfoundation.org