Skip to content

update cyclonedds and iceoryx version#1248

Merged
clalancette merged 2 commits intoros2:masterfrom
wep21:cyclonedds-0.9.0
Mar 21, 2022
Merged

update cyclonedds and iceoryx version#1248
clalancette merged 2 commits intoros2:masterfrom
wep21:cyclonedds-0.9.0

Conversation

@wep21
Copy link
Copy Markdown
Contributor

@wep21 wep21 commented Mar 17, 2022

This is blocked by ros2/rmw_cyclonedds#379.

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Mar 17, 2022

@eboasson Is there another valid branch or tag for cyclonedds 0.9.0?

@eboasson
Copy link
Copy Markdown
Contributor

@wep21 double checking that it all builds properly before making that branch. I expect there'll be a releases/0.9.x branch and a new tag later today.

@eboasson
Copy link
Copy Markdown
Contributor

Full CI of this PR + ros2/rmw_cyclonedds#379

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@eboasson
Copy link
Copy Markdown
Contributor

eboasson commented Mar 18, 2022

CI for only cyclonedds to verify that the

projectroot.src.core.ddsc.tests.start_roudi
test failure in the full CI run above is now gone:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

All the other failures appear to be unrelated to the proposed change.

@wep21
Copy link
Copy Markdown
Contributor Author

wep21 commented Mar 18, 2022

cc @clalancette

@eboasson
Copy link
Copy Markdown
Contributor

And another one of just Cyclone DDS — hopefully this eliminates the CMake warning on Windows:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@eboasson
Copy link
Copy Markdown
Contributor

Copy-paste from ros2/rmw_cyclonedds#379 (comment) of a full CI run that should end up green because it has the shared memory & the Windows CMake issues sorted:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

The one failure on Linux looks like is has been in the repeated jobs as well: https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/2594/#showFailuresLink . So that is all looking good.

I'm going to go ahead and approve this one, but someone needs to finish the review of ros2/rmw_cyclonedds#379 and approve it.

With that done, is it enough to merge this one and ros2/rmw_cyclonedds#379 ? Is there anything else needed?

@sumanth-nirmal
Copy link
Copy Markdown
Contributor

sumanth-nirmal commented Mar 21, 2022

With that done, is it enough to merge this one and ros2/rmw_cyclonedds#379 ? Is there anything else needed?

@clalancette I think its enough to merge this one and ros2/rmw_cyclonedds#379, @eboasson @MatthiasKillat @dkroenke please correct me if there is anything else to be done here

@MatthiasKillat
Copy link
Copy Markdown

MatthiasKillat commented Mar 21, 2022

@sumanth-nirmal @clalancette @eboasson No, these two PRs are required and sufficient to upgrade ROS 2 to use iceoryx 2.0 and cyclonedds 0.9.x. For me shared memory works with those changes and all other ROS rolling repos (within the stated QoS and type constraints).

@clalancette clalancette merged commit 781a67d into ros2:master Mar 21, 2022
@wep21 wep21 deleted the cyclonedds-0.9.0 branch March 21, 2022 16:01
Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
* update cyclonedds and iceoryx version

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants