update cyclonedds and iceoryx version#1248
Conversation
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
|
@eboasson Is there another valid branch or tag for cyclonedds 0.9.0? |
|
@wep21 double checking that it all builds properly before making that branch. I expect there'll be a |
|
Full CI of this PR + ros2/rmw_cyclonedds#379 |
|
CI for only cyclonedds to verify that the projectroot.src.core.ddsc.tests.start_roudi All the other failures appear to be unrelated to the proposed change. |
|
cc @clalancette |
|
Copy-paste from ros2/rmw_cyclonedds#379 (comment) of a full CI run that should end up green because it has the shared memory & the Windows CMake issues sorted: |
|
The one failure on Linux looks like is has been in the repeated jobs as well: https://ci.ros2.org/view/nightly/job/nightly_linux_repeated/2594/#showFailuresLink . So that is all looking good. I'm going to go ahead and approve this one, but someone needs to finish the review of ros2/rmw_cyclonedds#379 and approve it. With that done, is it enough to merge this one and ros2/rmw_cyclonedds#379 ? Is there anything else needed? |
@clalancette I think its enough to merge this one and ros2/rmw_cyclonedds#379, @eboasson @MatthiasKillat @dkroenke please correct me if there is anything else to be done here |
|
@sumanth-nirmal @clalancette @eboasson No, these two PRs are required and sufficient to upgrade ROS 2 to use iceoryx 2.0 and cyclonedds 0.9.x. For me shared memory works with those changes and all other ROS rolling repos (within the stated QoS and type constraints). |
* update cyclonedds and iceoryx version Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
This is blocked by ros2/rmw_cyclonedds#379.