Add keyboard_handler to ros2.repos#1184
Merged
clalancette merged 1 commit intoros2:masterfrom Sep 27, 2021
Merged
Conversation
Contributor
Author
|
Bump - this is now blocking ros2/rosbag2#847, which introduces a dependency on this package. |
Contributor
Author
|
@clalancette can you assign a reviewer for this? it's going to be blocking the rosbag2 PR momentarily. Thanks! |
clalancette
approved these changes
Sep 24, 2021
Contributor
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
Author
|
We will be adding this as a dependency of rosbag2, so it will need to be in this file for CI builds
6ca599e to
2f2f2f9
Compare
Contributor
Author
|
Both test failures are unrelated to keyboard handler - would we be cleared to move forward with this PR? |
Jiusi-pys
pushed a commit
to Jiusi-pys/ros2
that referenced
this pull request
Jan 17, 2026
We will be adding this as a dependency of rosbag2, so it will need to be in this file for CI builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will be adding this as a dependency of rosbag2 for Humble, so it will need to be in this file for CI builds