Conversation
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
@EduPonz It looks like |
|
@jacobperron This should have been fixed on eProsima/Fast-DDS@30c143f |
|
@MiguelCompany Thanks. Looks like there's still an issue with the Windows build: |
|
@jacobperron The only difference I've seen is that I've been investigating a bit, and checked that adding Is my reasoning correct? |
|
Certainly ros2/rmw_fastrtps#487 makes sense. Considering |
|
@jacobperron Now that ros2/rmw_fastrtps#487 has been merged, could you relaunch CI on this one? |
|
Hi @jacobperron @clalancette , Is their any blocker for this? Anything we can do on our side? |
|
All right, the failures on Windows are well-known. So I'm going to go ahead and merge this in. |
|
Awesome! |
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@EduPonz Let me know if this change looks good to you and I'll trigger CI.