Skip to content

Update to Fast-DDS 2.1.x#1058

Merged
clalancette merged 1 commit intomasterfrom
jacob/fastdds_2.1.x
Jan 11, 2021
Merged

Update to Fast-DDS 2.1.x#1058
clalancette merged 1 commit intomasterfrom
jacob/fastdds_2.1.x

Conversation

@jacobperron
Copy link
Copy Markdown
Member

@EduPonz Let me know if this change looks good to you and I'll trigger CI.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron changed the title Update to Fast-DDS 2.0.x Update to Fast-DDS 2.1.x Nov 16, 2020
Copy link
Copy Markdown

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Nov 16, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron
Copy link
Copy Markdown
Member Author

@EduPonz It looks like rmw_fastrtps_shared_cpp is failing to build.

@MiguelCompany
Copy link
Copy Markdown
Contributor

@jacobperron This should have been fixed on eProsima/Fast-DDS@30c143f

@jacobperron
Copy link
Copy Markdown
Member Author

@MiguelCompany Thanks. Looks like there's still an issue with the Windows build:

C:\ci\ws\install\include\fastdds/rtps/builtin/discovery/endpoint/EDP.h(32,10): fatal error C1083: Cannot open include file: 'foonathan/memory/container.hpp': No such file or directory

@MiguelCompany
Copy link
Copy Markdown
Contributor

@jacobperron The only difference I've seen is that --merge-install is only used on Windows.

I've been investigating a bit, and checked that adding foonathan_memory here also solves the problem. I don't know if that would be the best solution, though, as the error comes from including a header that is not necessary. That's why I have created ros2/rmw_fastrtps#487 instead.

Is my reasoning correct?

@jacobperron
Copy link
Copy Markdown
Member Author

Certainly ros2/rmw_fastrtps#487 makes sense.

Considering rmw_fastrtps does not directly depend on foonathan_memory, we should have to explicitly link against foonathan_memory. Sounds like maybe fastdds is not exporting all the necessary info about it's dependency on foonathan_memory, and doing a merge install revealed this. This is just all speculation though, I haven't dug into it.

@MiguelCompany
Copy link
Copy Markdown
Contributor

@jacobperron Now that ros2/rmw_fastrtps#487 has been merged, could you relaunch CI on this one?

@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Nov 20, 2020

  • Windows Build Status (edit: retriggered with fast-dds only)

@EduPonz
Copy link
Copy Markdown

EduPonz commented Jan 11, 2021

Hi @jacobperron @clalancette ,

Is their any blocker for this? Anything we can do on our side?

@clalancette
Copy link
Copy Markdown
Contributor

clalancette commented Jan 11, 2021

Let me run CI on the whole thing again and see what it looks like:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@clalancette
Copy link
Copy Markdown
Contributor

All right, the failures on Windows are well-known. So I'm going to go ahead and merge this in.

@clalancette clalancette merged commit 57b618f into master Jan 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the jacob/fastdds_2.1.x branch January 11, 2021 21:15
@EduPonz
Copy link
Copy Markdown

EduPonz commented Jan 12, 2021

Awesome!

Jiusi-pys pushed a commit to Jiusi-pys/ros2 that referenced this pull request Jan 17, 2026
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants