Move xmlrpcpp find_package so it only searches if ROS 1 is found#371
Merged
Move xmlrpcpp find_package so it only searches if ROS 1 is found#371
Conversation
Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
Member
Author
|
CI: |
Member
Author
|
Trying again, with actually including |
Member
Author
|
Third time lucky! |
hsd-dev
added a commit
to hsd-dev/ros1_bridge
that referenced
this pull request
Mar 27, 2023
…2#371) Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> # Conflicts: # CMakeLists.txt Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
lucyannofrota
added a commit
to lucyannofrota/ros1_bridge
that referenced
this pull request
May 15, 2023
Reproduces the changes made in ros2#371 in ros foxy. Move xmlrpcpp find_package so it only searches if ROS 1 is found Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com>
lucyannofrota
added a commit
to lucyannofrota/ros1_bridge
that referenced
this pull request
May 23, 2023
Reproduces the changes made in ros2#371 in ros foxy. Move xmlrpcpp find_package so it only searches if ROS 1 is found Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com>
quarkytale
pushed a commit
that referenced
this pull request
May 24, 2023
… commits (ec44770) and (86b4245) to foxy branch] (#401) * Port of the commit (ec44770) to foxy branch Just reproduces the changes made in #331 in ros foxy. Parametrize Quality of Service in `parameter_bridge` Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com> * Port of the commit (86b4245) to foxy branch Reproduces the changes made in #371 in ros foxy. Move xmlrpcpp find_package so it only searches if ROS 1 is found Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com> * CI fix White spaces removed Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com> --------- Signed-off-by: Lucyanno Frota <lucyannofrota@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
xmlrpcppdependency search only occur if ROS 1 is found. This is because on a system with only ROS 2 installed,xmlrpcppmight not be installed, leading to the build ofros1_bridgefailing for an unexpected (by the user) reason.For more info, see this comment: #331 (comment)