[backport] export find_ros1_package cmake extras#172
Merged
Karsten1987 merged 1 commit intocrystalfrom Mar 11, 2019
Merged
Conversation
* export find_ros1_package cmake Signed-off-by: Karsten Knese <karsten@openrobotics.org> * export pkg-config dependency Signed-off-by: Karsten Knese <karsten@openrobotics.org> * use buildtool_export_depend Signed-off-by: Karsten Knese <karsten@openrobotics.org> * make pkg-config required Signed-off-by: Karsten Knese <karsten@openrobotics.org> * also export cmake macros if ros1 is not found Signed-off-by: Karsten Knese <karsten@openrobotics.org> * set cmake files in variable Signed-off-by: Karsten Knese <karsten@openrobotics.org> * use set instead of list Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Member
|
Since the title will become the commit message when squash merging please include enough information in it as well as write a description what the PR actually backports. |
10 tasks
Member
|
CI running bridge tests |
nuclearsandwich
approved these changes
Mar 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows other packages to use macros to find ros1 packages straight after finding the
ros1_bridgepackage.see: ros2/rosbag2#90 (comment)