Conversation
|
CI packaging job to test the bridge |
|
👍 This will fix the imminent problem and not link against I am wondering though if this works if ROS 1 is built in isolation. Are the services in the |
|
|
sloretz
left a comment
There was a problem hiding this comment.
The change seems safe, though it seems likely to happen again unless there is a way to link against just the generated message library in a package instead of all libraries in a package.
|
The right solution to this problem is to ensure that the class loader used in ROS 1 and ROS 2 can be used at the same time, either by using different namespaces or by hiding conflicting symbols so they don't collide at link time or by making it so that the same exact version of class loader is used in both. |
wjwwood
left a comment
There was a problem hiding this comment.
lgtm as a workaround, though there should be at least a TODO about it in the code and probably an issue.
The chances of someone fixing this problem down the road and remembering to change this, without an issue or TODO to cross reference, is pretty small in my opinion.
|
I went ahead and merged this. I've put a TODO in the CMakeLists and opened an issue on ros/class_loader. |
* exclude ros1 nodelets * find_package() only if neccessary * add todo Signed-off-by: Dhananjay Sathe <dhananjay.sathe@rapyuta-robotics.com>
connects to ros2/rosbag2#69
this PR excludes nodelets so that rosbag2 can replay ros1 bag files without linking conflicts.