Merged
Conversation
Member
Author
|
CI with 2 RMWs:
CI with 1 RMW:
|
This was referenced Jul 16, 2018
Member
Author
|
While this commit (ament/ament_cmake@8003349) was added after CI was triggered the results still hold. Obviously there were no |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where
selected_rmw_implementationisrmw_implementationit shouldn't callfind_packagefor it since the entire logic already happens in the CMake config file ofrmw_implementationso it is already "inside" afind_package(rmw_implementation)call.This only doesn't end in an infinite recursion due to the custom logic in the generated CMake config files which returns early from repeated finds: https://github.com/ament/ament_cmake/blob/6d171d79584319c216e6880c46372224cd3ae6eb/ament_cmake_core/cmake/core/templates/nameConfig.cmake.in#L3-L7
Connect to ros2/ros2#544.