Skip to content

Add tests for localhost-only node creation#150

Merged
Lobotuerk merged 2 commits intomasterfrom
lobotuerk/node-localhost-tests
Sep 30, 2020
Merged

Add tests for localhost-only node creation#150
Lobotuerk merged 2 commits intomasterfrom
lobotuerk/node-localhost-tests

Conversation

@Lobotuerk
Copy link
Copy Markdown
Contributor

Tests added to up line-based coverage on rmw_implementations
Signed-off-by: lobotuerk jtlorente@ekumenlabs.com

Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk Lobotuerk requested review from ahcorde and hidmic September 30, 2020 16:56
Copy link
Copy Markdown

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@hidmic
Copy link
Copy Markdown

hidmic commented Sep 30, 2020

Add tests for non-localhost node creation #150

Isn't it localhost-only node creation?

@Lobotuerk Lobotuerk changed the title Add tests for non-localhost node creation Add tests for localhost-only node creation Sep 30, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
@Lobotuerk
Copy link
Copy Markdown
Contributor Author

CI job up to test_rmw_implementaiton:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Lobotuerk Lobotuerk requested a review from Blast545 September 30, 2020 19:08
Copy link
Copy Markdown
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lobotuerk
Copy link
Copy Markdown
Contributor Author

Merging after green CI

@Lobotuerk Lobotuerk merged commit 44ea8ae into master Sep 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the lobotuerk/node-localhost-tests branch September 30, 2020 19:43
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
Signed-off-by: lobotuerk <jtlorente@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants