Skip to content

Use 10x the intraprocess delay to wait for sent requests.#148

Merged
hidmic merged 3 commits intomasterfrom
hidmic/fix-flaky-service-test
Sep 30, 2020
Merged

Use 10x the intraprocess delay to wait for sent requests.#148
hidmic merged 3 commits intomasterfrom
hidmic/fix-flaky-service-test

Conversation

@hidmic
Copy link
Copy Markdown

@hidmic hidmic commented Sep 30, 2020

Follow-up after #141.

CI up to test_rmw_implementation:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from Lobotuerk September 30, 2020 16:47
Copy link
Copy Markdown
Contributor

@Lobotuerk Lobotuerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Copy Markdown
Author

hidmic commented Sep 30, 2020

I don't understand cpplint logic. Oh well.

@hidmic
Copy link
Copy Markdown
Author

hidmic commented Sep 30, 2020

Alright, CI's green. Going in!

@hidmic hidmic merged commit 11b5845 into master Sep 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-flaky-service-test branch September 30, 2020 18:04
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants