Add fault injection tests to construction/destruction APIs. #144
Merged
Add fault injection tests to construction/destruction APIs. #144
Conversation
6ad410c to
8211835
Compare
Author
|
CI up to
|
brawner
reviewed
Sep 30, 2020
| rmw_client_t * client = | ||
| rmw_create_client(node, ts, service_name, &rmw_qos_profile_default); | ||
| if (client) { | ||
| int64_t count = rcutils_fault_injection_get_count(); |
Contributor
There was a problem hiding this comment.
Pausing the fault_injection happens a lot in these tests. If there isn't time to create a more obvious function call or macro, I would add a comment here so it's more clear why this is being done. Here and in the cases below.
Author
There was a problem hiding this comment.
Alright, let's add it. I have to re-release rmw_fastrtps anyways, adding rcutils to the queue won't hurt.
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
5ebb778 to
7c8618d
Compare
Author
|
CI up to
|
brawner
reviewed
Sep 30, 2020
| ROSIDL_GET_SRV_TYPE_SUPPORT(test_msgs, srv, BasicTypes); | ||
| RCUTILS_FAULT_INJECTION_TEST( | ||
| { | ||
| int64_t count = rcutils_fault_injection_get_count(); |
Contributor
There was a problem hiding this comment.
This is missing RCUTILS_NO_FAULT_INJECTION
| { | ||
| constexpr char node_name[] = "my_node"; | ||
| constexpr char node_namespace[] = "/my_ns"; | ||
| int64_t count = rcutils_fault_injection_get_count(); |
| rmw_publisher_t * pub = | ||
| rmw_create_publisher(node, ts, topic_name, &rmw_qos_profile_default, &options); | ||
| if (pub) { | ||
| int64_t count = rcutils_fault_injection_get_count(); |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
0ec4a9b to
7309204
Compare
brawner
approved these changes
Sep 30, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
CI up to
|
Author
|
Hmm, CI failures appear to be coming from a different thread. I'll dig in. |
Author
|
CI again after ros2/rmw_fastrtps#458:
|
Author
|
@ros-pull-request-builder retest this please |
1 similar comment
Author
|
@ros-pull-request-builder retest this please |
Author
|
All green ! Going in. |
ahcorde
pushed a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde
pushed a commit
that referenced
this pull request
Oct 21, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests aims to add fault injections tests for most if not all
rmwAPIs.