Skip to content

Check that rmw_init() fails if no enclave is given.#113

Merged
jacobperron merged 1 commit intomasterfrom
hidmic/require-enclave
Jul 9, 2020
Merged

Check that rmw_init() fails if no enclave is given.#113
jacobperron merged 1 commit intomasterfrom
hidmic/require-enclave

Conversation

@hidmic
Copy link
Copy Markdown

@hidmic hidmic commented Jul 6, 2020

Connected to ros2/rmw#247.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested review from Blast545 and brawner July 6, 2020 20:25
@hidmic
Copy link
Copy Markdown
Author

hidmic commented Jul 6, 2020

Running CI up to test_rmw_implementation and all RMW implementations:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Copy Markdown
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobperron
Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Copy Markdown
Member

@ros-pull-request-builder retest this please

Copy link
Copy Markdown
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm going to go ahead and merge this now that the PR job is happy.

@jacobperron jacobperron merged commit 678f2c6 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/require-enclave branch July 9, 2020 21:13
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 21, 2020
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants