Use unique mangled names when creating Content Filter Topics (backport #762)#768
Merged
fujitatomoya merged 1 commit intohumblefrom Jun 12, 2024
Merged
Use unique mangled names when creating Content Filter Topics (backport #762)#768fujitatomoya merged 1 commit intohumblefrom
fujitatomoya merged 1 commit intohumblefrom
Conversation
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> Signed-off-by: Mario-DL <mariodominguez@eprosima.com> (cherry picked from commit 97edce2)
fujitatomoya
approved these changes
Jun 5, 2024
Collaborator
|
CI:
|
Collaborator
Collaborator
|
windows failure is unrelated, https://ci.ros2.org/job/ci_windows/21957/#showFailuresLink |
Collaborator
|
Linux-rhel full build with 17:04:53 [ 88%] Running SIP generator for qt_gui_cpp_sip Python bindings...
17:04:53 sip: /usr/lib64/python3.9/site-packages/PyQt5/bindings/QtCore/QtCoremod.sip:23: syntax error
17:04:53 Traceback (most recent call last):
17:04:53 File "/home/jenkins-agent/workspace/ci_linux-rhel/ws/install/python_qt_binding/share/python_qt_binding/cmake/sip_configure.py", line 123, in <module>
17:04:53 subprocess.check_call(cmd)
17:04:53 File "/usr/lib64/python3.9/subprocess.py", line 373, in check_call
17:04:53 raise CalledProcessError(retcode, cmd)
17:04:53 subprocess.CalledProcessError: Command '['/usr/bin/sip', '-c', '/home/jenkins-agent/workspace/ci_linux-rhel/ws/build/qt_gui_cpp/sip/qt_gui_cpp_sip', '-b', '/home/jenkins-agent/workspace/ci_linux-rhel/ws/build/qt_gui_cpp/sip/qt_gui_cpp_sip/pyqtscripting.sbf', '-I', '/usr/lib64/python3.9/site-packages/PyQt5/bindings', '-w', '-n', 'PyQt5.sip', '-t', 'Qt_5_15_0', '-t', 'WS_X11', 'qt_gui_cpp.sip']' returned non-zero exit status 1.
17:04:53 gmake[2]: *** [src/qt_gui_cpp_sip/CMakeFiles/libqt_gui_cpp_sip.dir/build.make:103: sip/qt_gui_cpp_sip/Makefile] Error 1
17:04:53 gmake[1]: *** [CMakeFiles/Makefile2:253: src/qt_gui_cpp_sip/CMakeFiles/libqt_gui_cpp_sip.dir/all] Error 2
17:04:53 gmake: *** [Makefile:146: all] Error 2 |
Collaborator
|
CI(retry):
|
Collaborator
|
CI( with
Note, Humble targeted RHEL 8 |
Collaborator
|
@ahcorde @clalancette do you know why Linux-rhel CI is failing, i am not sure... |
Contributor
The worker disconnected, it is running as https://ci.ros2.org/job/ci_linux-rhel/729/ now. |
Collaborator
|
CI( with
Note, Humble targeted RHEL 8 |
Collaborator
|
CI(
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes every Content Filter Name unique by adding a static atomic counter. With this change, two or more content-filtered subscriptions can be created for the same topic name.
Tests are included in the following related PRs
This is an automatic backport of pull request Use unique mangled names when creating Content Filter Topics #762 done by Mergify.