Add in support for the MESSAGE_LOST event.#584
Closed
clalancette wants to merge 1 commit intomasterfrom
Closed
Conversation
Fast-DDS (and rmw_fastrtps_cpp) don't fully support this right now, but having it in the list here allows RViz2 to start up. Implementation extracted from #583, which is the more complete solution. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Contributor
Author
|
CI:
|
Merged
hidmic
reviewed
Feb 16, 2022
hidmic
left a comment
There was a problem hiding this comment.
@clalancette This LGTM pending green CI, but I wonder, why not simply review and merge #584?
Contributor
Author
I assume you mean #583. The main reason is that #583 is adding in support for some other events as well, and that is causing lots of spam on the terminal, as well as failed tests. I want to get just this piece of it in ASAP, because until this is in RViz2 is completely broken on Rolling. |
wjwwood
reviewed
Feb 16, 2022
Member
wjwwood
left a comment
There was a problem hiding this comment.
One question about the approach, but looks good for the most part.
wjwwood
approved these changes
Feb 16, 2022
fujitatomoya
approved these changes
Feb 16, 2022
Collaborator
|
@clalancette @fujitatomoya Please see my comment on #583 |
Contributor
Author
|
Closing since we merged #583 in instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-DDS (and rmw_fastrtps_cpp) don't fully support this right
now, but having it in the list here allows RViz2 to start up.
Implementation extracted from
#583, which is the more
complete solution.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
This also requires a small fix in rcl, which is upcoming.
@MiguelCompany FYI. We really need to fix RViz2, and the only part we need in order to do that is the MESSAGE_LOST fix. So this just extracts the necessary bits from #583 so we can get it in faster. We can rebase 583 on top of this later on.